Update ForceFlush behavior to meet with the latest spec requirements #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mic-max
reviewed
Sep 20, 2021
| var sw = Stopwatch.StartNew(); | ||
|
|
||
| while (cur != null) | ||
| { | ||
| if (timeoutMilliseconds == Timeout.Infinite) | ||
| { | ||
| _ = cur.Value.ForceFlush(Timeout.Infinite); | ||
| result = cur.Value.ForceFlush(Timeout.Infinite) && result; |
There was a problem hiding this comment.
I think no, &= has different semantic (short-circuit ForceFlush when result is true) than what we need (ForceFlush would always be called).
pellared
approved these changes
Sep 20, 2021
Codecov Report
@@ Coverage Diff @@
## main #2388 +/- ##
==========================================
+ Coverage 79.91% 79.93% +0.01%
==========================================
Files 231 231
Lines 7445 7440 -5
==========================================
- Hits 5950 5947 -3
+ Misses 1495 1493 -2
|
cijothomas
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2386.
Related to #2385.
Changes
Infinite(`-1).CompositeProcessor.OnForceFlushlogic to meet with the latest spec requirement (also aligns with metrics SDK spec).On...callbacks (because they will not be called by end users).For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes