HTTP retries and redirects instrumentation #2756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisivan0v
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2756 +/- ##
==========================================
+ Coverage 83.75% 83.79% +0.03%
==========================================
Files 251 251
Lines 8864 8879 +15
==========================================
+ Hits 7424 7440 +16
+ Misses 1440 1439 -1
|
mic-max
reviewed
Dec 30, 2021
test/OpenTelemetry.Instrumentation.Http.Tests/HttpWebRequestActivitySourceTests.netfx.cs
Outdated
Show resolved
Hide resolved
…tivitySourceTests.netfx.cs Co-authored-by: Michael Maxwell <mike.ian.maxwell@gmail.com>
mic-max
reviewed
Jan 25, 2022
src/OpenTelemetry.Instrumentation.Http/HttpRequestMessageContextPropagation.cs
Outdated
Show resolved
Hide resolved
…xtPropagation.cs Co-authored-by: Michael Maxwell <mike.ian.maxwell@gmail.com>
cijothomas
reviewed
Jan 27, 2022
| retryCount = (int)previousRetryCount + 1; | ||
| } | ||
|
|
||
| // Suppressing activity started by HttpClient DiagnosticsHandler. |
There was a problem hiding this comment.
this section is a bit unclear without some examples and explanation.
some questions:
- Does httpClient diagnostichandler created a single Activity only, or does it create one for every retry?
- Which one are we stopping here.
- We are creating a new activity here - is it supposed to be the child of the original http client activity or is it expected to be its sibling (i.e same parent, likely that of the Asp.Net Core Request)
- Why do we explicitly set Activity.Current in line 108?
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
github-actions
bot
added
the
Stale
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR brings an implementation for HTTP retries and redirects proposed in opentelemetry-specification #2078.
It addresses a scenario which is in the scope for bringing the existing HTTP semantic conventions for tracing to an initial stable state, see related otep #174.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes