Logs: Add LogEmitter API #3423
Merged
Logs: Add LogEmitter API #3423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3423 +/- ##
==========================================
- Coverage 86.22% 86.18% -0.05%
==========================================
Files 261 263 +2
Lines 9411 9542 +131
==========================================
+ Hits 8115 8224 +109
- Misses 1296 1318 +22
|
alanwest
reviewed
Jul 9, 2022
| var logEmitter = provider.CreateEmitter(); | ||
|
|
||
| DateTime timestamp = DateTime.SpecifyKind( | ||
| new DateTime(2022, 6, 30, 16, 0, 0), |
There was a problem hiding this comment.
I'm inclined to suggest using some well-known historical date here, but no great ones are jumping to my mind 😆
There was a problem hiding this comment.
Are you saying the date that I wrote the test is NOT historically significant?! 🤣
alanwest
approved these changes
Jul 9, 2022
cijothomas
approved these changes
Jul 11, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Goal is to pare down the amount of changes on #3305]
Changes
I didn't implement
LogEmitterProviderbecause it didn't seem to really be needed. Users can getLogEmitterviaOpenTelemetryLoggerProvider.CreateEmitter.TODOs
* [ ] AppropriateThis is all internal so I'm not going to add a CHANGELOG entry. We can add if/when it becomes public? If anyone thinks it should be there LMK.CHANGELOG.mdupdated for non-trivial changes