Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs] Add named options support to OtlpLogExporter builder extensions. #3652

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Sep 13, 2022

Changes

Applies the named options pattern from #3648 to OtlpLogExporter.

TODOs

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Unit Tests
  • Changes in public API reviewed

@CodeBlanch CodeBlanch requested a review from a team September 13, 2022 16:59
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #3652 (1c8ea31) into main (79d8714) will decrease coverage by 0.23%.
The diff coverage is 80.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3652      +/-   ##
==========================================
- Coverage   87.83%   87.60%   -0.24%     
==========================================
  Files         283      283              
  Lines       10215    10218       +3     
==========================================
- Hits         8972     8951      -21     
- Misses       1243     1267      +24     
Impacted Files Coverage Δ
...ryProtocol.Logs/OtlpLogExporterHelperExtensions.cs 91.66% <80.00%> (+1.19%) ⬆️
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 35.71% <0.00%> (-42.86%) ⬇️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 36.36% <0.00%> (-40.91%) ⬇️
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 91.75% <0.00%> (-3.30%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️
...tpListener/Internal/PrometheusCollectionManager.cs 78.04% <0.00%> (-2.44%) ⬇️
...Propagators/OpenTelemetryPropagatorsEventSource.cs 100.00% <0.00%> (+12.50%) ⬆️

@CodeBlanch CodeBlanch merged commit de98eb7 into open-telemetry:main Sep 13, 2022
@CodeBlanch CodeBlanch deleted the otlp-logs-namedoptions branch September 13, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants