-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Adjust filtering processor guidance #3834
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3834 +/- ##
==========================================
- Coverage 87.48% 87.40% -0.09%
==========================================
Files 280 280
Lines 10767 10767
==========================================
- Hits 9420 9411 -9
- Misses 1347 1356 +9
|
@CodeBlanch - Filter by setting |
@vishweshbankwar Customer wants to filter based on some data on the |
We should be only showing the OnEnd based filter as shown in this PR. There is not much value in showing Filter based on OnStart(), as Sampler is a better fit there. OnEnd is more like "tail" based filtering, based on data not available at SpanStart/Sample time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The previous "FilteringProcessor" example required manually constructing the exporter and passing it into the processor. Many exporters do not have a public ctor so it is not possible to construct them.
Changes
Switched the example to toggle
Activity.Recorded
instead. This works because BatchActivityExportProcessor and SimpleActivityExportProcessor both no-op for this case.