Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert [sdk] Use reflection and dynamic types to start providers #4173

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

CodeBlanch
Copy link
Member

Reverts #4151

Rolling back the reflection emit IHostedService PR so we can explore some other options. This might come back pending that exploration.

@CodeBlanch CodeBlanch requested a review from a team February 9, 2023 17:50
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #4173 (9c6a232) into main (b549e12) will decrease coverage by 0.01%.
The diff coverage is 84.37%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4173      +/-   ##
==========================================
- Coverage   85.60%   85.59%   -0.01%     
==========================================
  Files         292      293       +1     
  Lines       11467    11371      -96     
==========================================
- Hits         9816     9733      -83     
+ Misses       1651     1638      -13     
Impacted Files Coverage Δ
...ensions.Hosting/OpenTelemetryServicesExtensions.cs 0.00% <0.00%> (ø)
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 80.46% <ø> (+0.32%) ⬆️
src/OpenTelemetry/OpenTelemetryBuilder.cs 63.63% <ø> (ø)
...ronmentVariables/EnvironmentVariablesExtensions.cs 40.00% <40.00%> (-60.00%) ⬇️
...ing/Implementation/HostingExtensionsEventSource.cs 100.00% <100.00%> (ø)
...s.Hosting/Implementation/TelemetryHostedService.cs 100.00% <100.00%> (ø)
...s.Hosting/OpenTelemetryBuilderHostingExtensions.cs 100.00% <100.00%> (ø)
...AspNetCore/Implementation/HttpInMetricsListener.cs 74.35% <100.00%> (ø)
...ementation/HttpHandlerMetricsDiagnosticListener.cs 95.00% <100.00%> (ø)
...emetry/OpenTelemetryServiceCollectionExtensions.cs 100.00% <100.00%> (ø)
... and 3 more

@CodeBlanch CodeBlanch merged commit 94f67d8 into open-telemetry:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants