Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pip to dbotconf #307

Merged
merged 13 commits into from
May 22, 2023
Merged

Add pip to dbotconf #307

merged 13 commits into from
May 22, 2023

Conversation

CharlieTLe
Copy link
Contributor

requirements.txt files will now be tracked with dependabot.

This is related to open-telemetry/opentelemetry-go#3996.

cc: @MrAlias @pellared

requirements.txt files will now be tracked with dependabot.

This is related to open-telemetry/opentelemetry-go#3996.
@CharlieTLe CharlieTLe requested review from a team and Aneurysm9 May 9, 2023 23:06
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 80.39% and project coverage change: +0.28 🎉

Comparison is base (748ea6a) 59.93% compared to head (37c46ee) 60.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
+ Coverage   59.93%   60.22%   +0.28%     
==========================================
  Files          47       47              
  Lines        2134     2172      +38     
==========================================
+ Hits         1279     1308      +29     
- Misses        715      721       +6     
- Partials      140      143       +3     
Impacted Files Coverage Δ
dbotconf/internal/generate.go 76.71% <64.70%> (-4.33%) ⬇️
dbotconf/internal/verify.go 82.29% <87.50%> (+0.95%) ⬆️
dbotconf/internal/mods.go 60.00% <100.00%> (+2.85%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Co-authored-by: Robert Pająk <pellared@hotmail.com>
@pellared
Copy link
Member

@CharlieTLe Please fix the issues reported by CI.

@pellared
Copy link
Member

https://github.com/open-telemetry/opentelemetry-go-build-tools/actions/runs/4952764204/jobs/8867985281?pr=307

No changelog entry was added to the ./.chloggen/ directory.
Please add a .yaml file to the ./.chloggen/ directory.
Run make chlog-new to add a new changelog file.

.chloggen/pip.yaml Outdated Show resolved Hide resolved
@CharlieTLe
Copy link
Contributor Author

Thanks for reviewing @pellared.

Can anyone with the 🪄 help merge this PR?

dbotconf/internal/conf.go Outdated Show resolved Hide resolved
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@CharlieTLe
Copy link
Contributor Author

@pellared @MrAlias OK to merge?

@MrAlias
Copy link
Contributor

MrAlias commented May 18, 2023

@pellared @MrAlias OK to merge?

We need another non-Splunk review.

@CharlieTLe
Copy link
Contributor Author

Hi @Aneurysm9, could you take a look? 🙂

@MrAlias MrAlias merged commit 6fd2bd7 into open-telemetry:main May 22, 2023
@CharlieTLe
Copy link
Contributor Author

CharlieTLe commented May 22, 2023

Thanks @MadVikingGod @MrAlias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants