Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-go should set the resource attribute telemetry.sdk.name to opentelemetry #1331

Closed
justinfoote opened this issue Nov 13, 2020 · 0 comments · Fixed by #1332
Closed
Assignees
Labels
area:resources Part of OpenTelemetry resources bug Something isn't working pkg:SDK Related to an SDK package
Milestone

Comments

@justinfoote
Copy link
Member

According to the spec:

The default OpenTelemetry SDK provided by the OpenTelemetry project MUST set telemetry.sdk.name to the value opentelemetry.

But the implementation in opentelemetry-go sets the value to "opentelemetry-go":

func (TelemetrySDK) Detect(context.Context) (*Resource, error) {
	return NewWithAttributes(
		semconv.TelemetrySDKNameKey.String("opentelemetry-go"),
		semconv.TelemetrySDKLanguageKey.String("go"),
		semconv.TelemetrySDKVersionKey.String(opentelemetry.Version()),
	), nil
}
@MrAlias MrAlias added area:resources Part of OpenTelemetry resources bug Something isn't working pkg:SDK Related to an SDK package priority:p1 labels Nov 13, 2020
@MrAlias MrAlias added this to the RC1 milestone Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:resources Part of OpenTelemetry resources bug Something isn't working pkg:SDK Related to an SDK package
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants