Set telemetry.sdk.name resource attribute to "opentelemetry" #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinfoote
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
MrAlias
added
area:resources
|
The tests need updates, but otherwise the fix looks good to me. |
Aneurysm9
approved these changes
Nov 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #1332 +/- ##
======================================
Coverage 77.3% 77.3%
======================================
Files 123 123
Lines 6067 6067
======================================
Hits 4693 4693
Misses 1121 1121
Partials 253 253
|
MrAlias
approved these changes
Nov 16, 2020
AzfaarQureshi
pushed a commit
to open-o11y/opentelemetry-go
that referenced
this pull request
Dec 3, 2020
…lemetry#1332) * Set telemetry.sdk.name resource attribute to "opentelemetry" * Update config_test.go to correct `telemetry.sdk.name` Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the value used in the default SDK for the "telemetry.sdk.name" attribute on a resource. The spec indicates that this value MUST be "opentelemetry".
Fixes #1331