Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check marshalled value instead of iface #1299

Merged
merged 4 commits into from
Nov 2, 2020
Merged

Check marshalled value instead of iface #1299

merged 4 commits into from
Nov 2, 2020

Conversation

dstdfx
Copy link
Contributor

@dstdfx dstdfx commented Oct 31, 2020

Fixes #1294

@dstdfx
Check marshalled value
b29433f 
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
@dstdfx
Update CHANGELOG.md
b60beac 
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
@codecov
Copy link

codecov bot commented Oct 31, 2020 •
edited
Loading

Codecov Report

Merging #1299 into master will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1299   +/-   ##
======================================
  Coverage    77.1%   77.1%           
======================================
  Files         123     123           
  Lines        5985    5985           
======================================
  Hits         4616    4616           
  Misses       1121    1121           
  Partials      248     248
Impacted Files Coverage Δ
label/kv.go 83.7% <100.0%> (ø)

MrAlias
MrAlias reviewed Nov 1, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
dstdfx and others added 2 commits November 2, 2020 09:08
@MrAlias MrAlias merged commit 911d7be into open-telemetry:master Nov 2, 2020
@dstdfx dstdfx deleted the fix/kv-any-condition branch November 3, 2020 08:32
@MrAlias MrAlias mentioned this pull request Nov 20, 2020
Merged
AzfaarQureshi pushed a commit to open-o11y/opentelemetry-go that referenced this pull request Dec 3, 2020
@dstdfx @MrAlias
Check marshalled value instead of iface (open-telemetry#1299)
637fa5f 
* Check marshalled value

Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>

* Update CHANGELOG.md

Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>

* Move change to Fixed section

Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@XSAM XSAM XSAM approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@jmacd jmacd Awaiting requested review from jmacd

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Static analysis error in label/kv.go
3 participants
@dstdfx @MrAlias @XSAM