Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zipkin example module name #1308

Merged
merged 2 commits into from
Nov 5, 2020
Merged

Conversation

krnowak
Copy link
Member

@krnowak krnowak commented Nov 5, 2020

No description provided.

@MrAlias MrAlias added the bug Something isn't working label Nov 5, 2020
@krnowak
Copy link
Member Author

krnowak commented Nov 5, 2020

I can't apply the skip changelog label myself.

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 5, 2020
@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #1308 into master will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1308     +/-   ##
========================================
- Coverage    77.1%   77.1%   -0.1%     
========================================
  Files         123     123             
  Lines        5985    5985             
========================================
- Hits         4620    4616      -4     
- Misses       1116    1121      +5     
+ Partials      249     248      -1     
Impacted Files Coverage Δ
sdk/trace/batch_span_processor.go 74.5% <0.0%> (-4.0%) ⬇️

@MrAlias MrAlias merged commit c9ae670 into open-telemetry:master Nov 5, 2020
@krnowak krnowak deleted the fix-mod-name branch November 5, 2020 16:12
AzfaarQureshi pushed a commit to open-o11y/opentelemetry-go that referenced this pull request Dec 3, 2020
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants