Update Span End method documentation #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to the Span after End is called result it potentially inconsistent views of the Span between the code defining it and the ultimate receiver of the Span data. This corrects the documented language of the API to prevent this from happening.
MrAlias
added
pkg:API
MrAlias
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey and
XSAM
as code owners
Aneurysm9
approved these changes
Nov 6, 2020
XSAM
approved these changes
Nov 9, 2020
Merged
AzfaarQureshi
pushed a commit
to open-o11y/opentelemetry-go
that referenced
this pull request
Dec 3, 2020
* Update Span End method documentation Updates to the Span after End is called result it potentially inconsistent views of the Span between the code defining it and the ultimate receiver of the Span data. This corrects the documented language of the API to prevent this from happening. * Add changes to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the Span after End is called result it potentially inconsistent views of the Span between the code defining it and the
ultimate receiver of the Span data. This corrects the documented language of the API to prevent this from happening.
Resolves #1275