Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move baggage and propagation to separate packages #1325

Merged
merged 4 commits into from
Nov 13, 2020

Conversation

krnowak
Copy link
Member

@krnowak krnowak commented Nov 12, 2020

One more step toward resolving #1303.

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #1325 (bc2f09f) into master (f6df5df) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1325   +/-   ##
======================================
  Coverage    77.3%   77.3%           
======================================
  Files         123     123           
  Lines        6067    6067           
======================================
  Hits         4694    4694           
  Misses       1120    1120           
  Partials      253     253           
Impacted Files Coverage Δ
baggage/baggage.go 100.0% <ø> (ø)
bridge/opentracing/bridge.go 39.0% <ø> (ø)
global/internal/state.go 100.0% <ø> (ø)
global/propagation.go 0.0% <ø> (ø)
oteltest/text_map_propagator.go 74.6% <ø> (ø)
propagation/baggage.go 86.3% <ø> (ø)
propagation/propagation.go 100.0% <ø> (ø)
propagation/trace_context.go 65.5% <ø> (ø)
global/internal/propagator.go 100.0% <100.0%> (ø)

baggage/baggage.go Outdated Show resolved Hide resolved
Copy link
Contributor

@seanschade seanschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added a few suggestions.

baggage/baggage.go Show resolved Hide resolved
baggage/baggage.go Show resolved Hide resolved
baggage/baggage.go Show resolved Hide resolved
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@MrAlias MrAlias merged commit 63a1114 into open-telemetry:master Nov 13, 2020
@krnowak krnowak deleted the new-api-4 branch November 13, 2020 15:46
AzfaarQureshi pushed a commit to open-o11y/opentelemetry-go that referenced this pull request Dec 3, 2020
* Move propagation code to propagation package

* Move baggage code to baggage package

* Update changelog

* Make docs of baggage.Set more clear

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants