-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate CircleCI ci.yml workflow to GitHub Actions #1382
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzfaarQureshi
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
December 2, 2020 23:06
AzfaarQureshi
force-pushed
the
migrate-to-gha
branch
from
December 2, 2020 23:07
070c60f
to
5649601
Compare
This was referenced Dec 2, 2020
dashpole
approved these changes
Dec 8, 2020
Aneurysm9
approved these changes
Dec 10, 2020
XSAM
approved these changes
Dec 13, 2020
MrAlias
reviewed
Dec 14, 2020
AzfaarQureshi
force-pushed
the
migrate-to-gha
branch
from
December 14, 2020 21:13
5649601
to
5544dde
Compare
MrAlias
approved these changes
Dec 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 👍
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do
This addresses issue #880 by migrating CI/CD from CircleCI to GitHub Actions
Changes
current-go
andprior-go
CircleCI jobs to GitHub ActionsMigration Plan
I suggest having CircleCI and GitHub Action jobs run in parallel for a few weeks. After the GitHub Action jobs are running fine for about a week, please remove the CircleCI workflows from
config.yml
cc- @alolita