-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement global default non-recording span #1901
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
bug
Something isn't working
area:trace
Part of OpenTelemetry tracing
release:1.0.0-rc.1
labels
May 11, 2021
Codecov Report
@@ Coverage Diff @@
## main #1901 +/- ##
=======================================
- Coverage 79.4% 79.3% -0.1%
=======================================
Files 139 139
Lines 7414 7425 +11
=======================================
+ Hits 5889 5892 +3
- Misses 1279 1286 +7
- Partials 246 247 +1
|
Aneurysm9
reviewed
May 12, 2021
MrAlias
requested review from
dashpole,
evantorrie,
jmacd,
paivagustavo and
XSAM
as code owners
May 12, 2021 15:26
dashpole
approved these changes
May 12, 2021
MadVikingGod
approved these changes
May 12, 2021
Aneurysm9
approved these changes
May 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a non-recording span implementation to the internal
global
package and returns that span implementation by default. This implementation, like the non-recording span implementation in thetrace
package, performs no operation except to return the parentSpanContext
of the span. This ensures traces are not broken if no SDK is registered.This copies the
nonRecordingSpan
implementation rather than importing it from a centralized package to avoid a dependency cycle. It may be possible through a large refactor to unify this, but that can be done in the future if there is ever deemed a sufficient need.Resolves #1893
Resolves #877