Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor exporter creation functions #1985

Merged
merged 14 commits into from
Jun 10, 2021
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jun 9, 2021

@MrAlias MrAlias added pkg:example Related to an example release:1.0.0-rc.1 pkg:exporter:prometheus Related to the Prometheus exporter package pkg:exporter:otlp Related to the OTLP exporter package pkg:exporter:stdout Related to the stdout exporter package pkg:exporter:jaeger Related to the Jaeger exporter package pkg:exporter:zipkin Related to the Zipkin exporter package labels Jun 9, 2021
@MrAlias MrAlias added this to the RC1 milestone Jun 9, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #1985 (437a168) into main (87cc1e1) will increase coverage by 0.0%.
The diff coverage is 14.2%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #1985   +/-   ##
=====================================
  Coverage   77.1%   77.2%           
=====================================
  Files        161     161           
  Lines       8593    8495   -98     
=====================================
- Hits        6631    6563   -68     
+ Misses      1701    1679   -22     
+ Partials     261     253    -8     
Impacted Files Coverage Δ
exporters/metric/prometheus/prometheus.go 64.2% <ø> (-0.6%) ⬇️
exporters/otlp/otlptrace/exporter.go 0.0% <0.0%> (-46.6%) ⬇️
...rs/otlp/otlptrace/internal/otlptracetest/client.go 0.0% <0.0%> (ø)
exporters/otlp/otlptrace/otlptracegrpc/exporter.go 0.0% <0.0%> (ø)
exporters/otlp/otlptrace/otlptracehttp/exporter.go 0.0% <0.0%> (ø)
exporters/stdout/exporter.go 71.4% <ø> (+54.1%) ⬆️
exporters/trace/jaeger/jaeger.go 94.2% <ø> (-0.4%) ⬇️
exporters/trace/zipkin/zipkin.go 70.1% <ø> (-3.0%) ⬇️
sdk/metric/processor/processortest/test.go 89.7% <ø> (ø)
exporters/otlp/otlp.go 90.9% <100.0%> (+6.9%) ⬆️
... and 2 more

exporters/otlp/otlptrace/exporter_test.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:example Related to an example pkg:exporter:jaeger Related to the Jaeger exporter package pkg:exporter:otlp Related to the OTLP exporter package pkg:exporter:prometheus Related to the Prometheus exporter package pkg:exporter:stdout Related to the stdout exporter package pkg:exporter:zipkin Related to the Zipkin exporter package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporter convenience functions do not set a service name by default
3 participants