Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on metrics packages #1988

Merged
merged 7 commits into from
Jun 10, 2021

Conversation

Aneurysm9
Copy link
Member

Creates a new internal/metric module and moves metric-related internals there. The metric-related test helpers from oteltest have moved to metric/oteltest. This should eliminate all dependence on the metrics API module from modules that will be declared stable at v1.0.0.

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #1988 (a25d3bd) into main (135ac4b) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #1988   +/-   ##
=====================================
  Coverage   77.2%   77.2%           
=====================================
  Files        161     162    +1     
  Lines       8495    8495           
=====================================
  Hits        6563    6563           
- Misses      1679    1680    +1     
+ Partials     253     252    -1     
Impacted Files Coverage Δ
internal/global/state.go 100.0% <ø> (ø)
internal/metric/global/meter.go 90.3% <ø> (ø)
metric/global/metric.go 66.6% <ø> (-33.4%) ⬇️
metric/metrictest/meter.go 98.6% <ø> (ø)
internal/metric/global/metric.go 100.0% <100.0%> (ø)
internal/internaltest/alignment.go 0.0% <0.0%> (-37.5%) ⬇️
metric/config.go 91.6% <0.0%> (-8.4%) ⬇️
metric/metric_instrument.go 87.4% <0.0%> (-0.7%) ⬇️
metric/metric.go 51.9% <0.0%> (-0.6%) ⬇️
... and 2 more

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving otel/oteltest to otel/metric/oteltest means that package name doesn't match the test package naming pattern we try to implement (i.e. ${PACKAGE_NAME}test). Can we rename it to metrictest?

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
@Aneurysm9 Aneurysm9 merged commit 7728a52 into open-telemetry:main Jun 10, 2021
@Aneurysm9 Aneurysm9 deleted the fix/metrics_b_gon branch June 10, 2021 19:05
@Aneurysm9 Aneurysm9 mentioned this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants