Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify and update OTLP trace exporter documentation #2053
Verify and update OTLP trace exporter documentation #2053
Changes from 24 commits
cae7a4c
604068f
cb6825c
d071601
f228643
c2699ab
f21d279
cd897ea
e3edec9
5608a4a
1b02def
af8e6ab
4f1cd37
e42228a
2ac7886
f6dea98
b594d45
6ccfb2c
8f471b0
1d274e4
6061d42
c437e21
7ef6815
50cfeac
1e4b69b
5359244
bf334b0
6df0c51
1fb0f70
aef81d7
7201c27
a0035bc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We miss information about configuration via environmental variables. I am not sure which are supported (you would need to check the code/godoc/changelog). Here are the docs for the env vars that in theory should be supported: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md.
Here is a README how the env vars are documented for Jaeger exporter: https://github.com/open-telemetry/opentelemetry-go/blob/main/exporters/jaeger/README.md#environment-variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this will help you;
opentelemetry-go/exporters/otlp/otlptrace/internal/otlpconfig/envconfig.go
Lines 70 to 137 in d5d4c87
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pellared can you add this in a follow on PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MrAlias Added to my TODO list. I will try to do it next week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 thanks 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR: #2222