Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Just a little typo fix in code documentation. #2159

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Just a little typo fix in code documentation. #2159

merged 2 commits into from
Aug 4, 2021

Conversation

willyrgf
Copy link
Contributor

@willyrgf willyrgf commented Aug 3, 2021

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 3, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@MrAlias MrAlias added blocked:CLA Waiting on CLA to be signed before progress can be made documentation Provides helpful information labels Aug 3, 2021
MrAlias
MrAlias reviewed Aug 3, 2021
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for the contribution. Only think needed is to sign the CLA.

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 3, 2021
@codecov
Copy link

codecov bot commented Aug 3, 2021 •
edited
Loading

Codecov Report

Merging #2159 (53a266d) into main (59a82eb) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2159     +/-   ##
=======================================
- Coverage   72.2%   72.2%   -0.1%     
=======================================
  Files        170     170             
  Lines      12076   12076             
=======================================
- Hits        8727    8724      -3     
- Misses      3109    3111      +2     
- Partials     240     241      +1
Impacted Files Coverage Δ
trace/config.go 57.3% <ø> (ø)
...s/otlp/otlptrace/internal/connection/connection.go 14.8% <0.0%> (-1.6%) ⬇️

@Aneurysm9 Aneurysm9 removed the blocked:CLA Waiting on CLA to be signed before progress can be made label Aug 4, 2021
@MrAlias MrAlias merged commit fcf945a into open-telemetry:main Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@MrAlias MrAlias MrAlias approved these changes

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@evantorrie evantorrie Awaiting requested review from evantorrie

@jmacd jmacd Awaiting requested review from jmacd

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@pellared pellared Awaiting requested review from pellared pellared is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

Assignees
No one assigned
Labels
documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willyrgf @Aneurysm9 @MrAlias