Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WithoutTimestamps work #2195

Merged
merged 3 commits into from
Aug 23, 2021
Merged

Conversation

luxas
Copy link
Contributor

@luxas luxas commented Aug 20, 2021

Hi! I noticed there's no handling for the WithoutTimestamps option in the stdouttrace package, so I've fixed that now :)

Thanks for looking at this. Maybe this can still be merged before v1.0.0, in order to not have clients depending on WithoutTimestamps doing nothing?

Thanks for this great project, really enjoying using OpenTelemetry 😄

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #2195 (6138c46) into main (85c27e0) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2195   +/-   ##
=====================================
  Coverage   72.8%   72.9%           
=====================================
  Files        177     177           
  Lines      12151   12161   +10     
=====================================
+ Hits        8852    8869   +17     
+ Misses      3060    3054    -6     
+ Partials     239     238    -1     
Impacted Files Coverage Δ
exporters/stdout/stdouttrace/trace.go 75.6% <100.0%> (+7.8%) ⬆️
...s/otlp/otlptrace/internal/connection/connection.go 16.4% <0.0%> (+1.5%) ⬆️
exporters/stdout/stdouttrace/config.go 100.0% <0.0%> (+17.3%) ⬆️

@MrAlias MrAlias merged commit add511c into open-telemetry:main Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants