Update metric types to not use pointer receivers #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods on the `Float64Gauge`, `Int64Gauge`, `Float64Counter`, `Int64Counter`, `Float64Measure`, and `Int64Measure` `struct`s do not need to mutate the internal state of the `struct` and can therefore be defined with value receivers instead. This aligns closer to the function signatures of each instruments constructor function. Additionally, this change means calls to these methods do not need an allocation to the heap. Resolves #440
MrAlias
requested review from
iredelmeier,
jmacd,
krnowak,
lizthegrey,
paivagustavo,
rghetia and
tedsuo
as code owners
krnowak
approved these changes
Feb 4, 2020
rghetia
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods on the
Float64Gauge,Int64Gauge,Float64Counter,Int64Counter,Float64Measure, andInt64Measurestructs do not need to mutate the internal state of thestructand can therefore be defined instead to have value receivers. This aligns closer to the function signatures of each instruments constructor function (which return values). Additionally, this change means calls to these methods do not need an allocation to the heap.Resolves #440