exporter/metric/stdout: fix incorrect code format comments for InstallNewPipeline #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wingyplus
requested review from
iredelmeier,
jmacd,
krnowak,
lizthegrey,
paivagustavo,
rghetia and
tedsuo
as code owners
wingyplus
force-pushed
the
fix-stdout-doc
branch
2 times, most recently
from
903399b
to
4fe1871
Compare
lizthegrey
approved these changes
Feb 16, 2020
krnowak
approved these changes
Feb 17, 2020
MrAlias
reviewed
Feb 19, 2020
exporter/metric/stdout/stdout.go
Outdated
| // ... | ||
| // } | ||
| // defer pipeline.Stop() | ||
| // | ||
| // ... Done |
There was a problem hiding this comment.
In your other PRs you indented this line as well. Should this be indented?
wingyplus
force-pushed
the
fix-stdout-doc
branch
from
4fe1871
to
3fc113c
Compare
MrAlias
approved these changes
Feb 19, 2020
jmacd
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This similar in PR #482 but it's appear in stdout metric exporter.