-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the random fixed size exemplar reservoir #4852
Merged
MrAlias
merged 18 commits into
open-telemetry:main
from
MrAlias:add-rand-fixed-size-res
Jan 29, 2024
Merged
Add the random fixed size exemplar reservoir #4852
MrAlias
merged 18 commits into
open-telemetry:main
from
MrAlias:add-rand-fixed-size-res
Jan 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
January 24, 2024 16:17
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4852 +/- ##
=======================================
+ Coverage 82.3% 82.5% +0.1%
=======================================
Files 228 230 +2
Lines 18569 18754 +185
=======================================
+ Hits 15300 15480 +180
- Misses 2981 2985 +4
- Partials 288 289 +1
|
dashpole
reviewed
Jan 24, 2024
Co-authored-by: David Ashpole <dashpole@google.com>
MrAlias
commented
Jan 25, 2024
MrAlias
force-pushed
the
add-rand-fixed-size-res
branch
from
January 25, 2024 16:52
0edbb7c
to
81d4492
Compare
dashpole
reviewed
Jan 25, 2024
Include a high-level overview of the algorithm implemented and clarify parameter names to be consistent.
MrAlias
commented
Jan 25, 2024
pellared
reviewed
Jan 26, 2024
pellared
approved these changes
Jan 26, 2024
pellared
approved these changes
Jan 26, 2024
dmathieu
approved these changes
Jan 29, 2024
hanyuancheung
approved these changes
Jan 29, 2024
dashpole
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #559
This PR is split from #4455
This adds a
Reservoir
implementation that will randomly sample a specified number of measurements as exemplars. An explanation of the algorithm is copied from the included comment within the PR: