-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webapp service name detector #562
Webapp service name detector #562
Conversation
resource-providers/src/main/java/io/opentelemetry/resourceproviders/ServiceNameChecker.java
Outdated
Show resolved
Hide resolved
...providers/src/main/java/io/opentelemetry/resourceproviders/AppServerServiceNameProvider.java
Outdated
Show resolved
Hide resolved
...providers/src/main/java/io/opentelemetry/resourceproviders/AppServerServiceNameProvider.java
Outdated
Show resolved
Hide resolved
…iders/AppServerServiceNameProvider.java Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
…iders/AppServerServiceNameProvider.java Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
package io.opentelemetry.resourceproviders; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can all of these classes go under an internal
package, or do users need access to them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the AppServerServiceNameProvider
will be the only real user-facing class (although the delegates could be too I suppose, if someone wanted to pull in only a subset of the supported app servers). For now, I think I should make the two interfaces package-private and that should help, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I think I should make the two interfaces package-private and that should help, right?
looks good, we can revisit visibility issues later too, thx
This is a continuation of #562 that introduces the first of several web app servers for which we will detect the service name. Because this is the first (GlassFish), it includes some of the helper/plumbing utilities. Subsequent additions will mostly be the `AppServer` implementations (and adding them to the delegate list).
This is the start of a few contributions of
ResourceDetector
implementations from the Splunk distro. The first one coming up here is theAppServerServiceNameProvider
. This will eventually detect when theservice.name
resource attribute is missing (and alsootel.service.name
not set in config) and will apply a series of heuristics for common application servers.Because the current implementation is not exactly small, it's being contributed piecemeal to make reviews easier. The implementation here doesn't actually apply any of the heuristics yet....to see what they'll look like when done, you can look in the splunk distribution impl.