Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and enhance resource detection logging. #711

Merged
merged 4 commits into from
Jan 31, 2023

Conversation

breedx-splk
Copy link
Contributor

@breedx-splk breedx-splk commented Jan 26, 2023

I learned (the hard way) today that jul doesn't expand numeric placeholders in string templates if they are surrounded by single quotes. Yup.

  • logger.log(INFO, "{0}", "test") -> test
  • logger.log(INFO, "'{0}'", "test") -> {0}

So this results in pretty useless logs here. I also used this as an opportunity to enhance the details about when/why the resource provider doesn't kick in.

@breedx-splk
Copy link
Contributor Author

❌ is a Sonatype flaky link failure in markdown check. Re-run should clear it up (I verified the link works).

@breedx-splk breedx-splk mentioned this pull request Jan 27, 2023
@mateuszrzeszutek
Copy link
Member

Thanks!

@mateuszrzeszutek mateuszrzeszutek merged commit d54b9ea into open-telemetry:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants