feat: instrumentation for apache httpclient 5 #10100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbiocaetano
force-pushed
the
main
branch
3 times, most recently
from
8a8da27
to
49f6a71
Compare
|
Could some maintainer (maybe @trask?) help me with the approval and also with fixing one test? It is failing, but I could not find the root cause for that. |
laurit
reviewed
Dec 20, 2023
There was a problem hiding this comment.
https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/docs/supported-libraries.md
should also be update to include this
A readme similar to https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/okhttp/okhttp-3.0/library/README.md should be added.
instrumentation/apache-httpclient/apache-httpclient-5.0/library/build.gradle.kts
Outdated
Show resolved
Hide resolved
instrumentation/apache-httpclient/apache-httpclient-5.0/library/build.gradle.kts
Outdated
Show resolved
Hide resolved
instrumentation/apache-httpclient/apache-httpclient-5.0/testing/build.gradle.kts
Outdated
Show resolved
Hide resolved
instrumentation/apache-httpclient/apache-httpclient-5.0/library/build.gradle.kts
Outdated
Show resolved
Hide resolved
.../java/io/opentelemetry/instrumentation/apachehttpclient/v5_0/ApacheHttpClient5Telemetry.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| /** Returns a new {@link HttpClientBuilder} to create a client with tracing configured. */ | ||
| public HttpClientBuilder newHttpClientBuilder() { |
There was a problem hiding this comment.
any plans to also instrument HttpAsyncClientBuilder?
There was a problem hiding this comment.
Yes, but in the future in a new PR. In the moment we only need the non async client
...c/main/java/io/opentelemetry/instrumentation/apachehttpclient/v5_0/OtelExecChainHandler.java
Outdated
Show resolved
Hide resolved
.../test/java/io/opentelemetry/instrumentation/apachehttpclient/v5_0/ApacheHttpClient5Test.java
Outdated
Show resolved
Hide resolved
...entelemetry/instrumentation/apachehttpclient/v5_0/ApacheHttpClient5HttpAttributesGetter.java
Outdated
Show resolved
Hide resolved
...ng/src/main/java/io/opentelemetry/instrumentation/apachehttpclient/v5_0/Http5UriRequest.java
Outdated
Show resolved
Hide resolved
elbiocaetano
force-pushed
the
main
branch
2 times, most recently
from
bd0e78f
to
2ea6ffa
Compare
jeanbisutti
reviewed
Jan 5, 2024
.../test/java/io/opentelemetry/instrumentation/apachehttpclient/v5_2/ApacheHttpClient5Test.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/apachehttpclient/v5_2/ApacheHttpClient5Request.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/opentelemetry/instrumentation/apachehttpclient/v5_2/OtelExecChainHandler.java
Outdated
Show resolved
Hide resolved
...va/io/opentelemetry/instrumentation/apachehttpclient/v5_2/AbstractApacheHttpClient5Test.java
Outdated
Show resolved
Hide resolved
elbiocaetano
force-pushed
the
main
branch
2 times, most recently
from
a061761
to
bdc85ac
Compare
laurit
reviewed
Jan 25, 2024
laurit
reviewed
Jan 25, 2024
instrumentation/apache-httpclient/apache-httpclient-5.2/library/README.md
Outdated
Show resolved
Hide resolved
laurit
reviewed
Jan 25, 2024
instrumentation/apache-httpclient/apache-httpclient-5.2/library/README.md
Outdated
Show resolved
Hide resolved
laurit
reviewed
Jan 25, 2024
instrumentation/apache-httpclient/apache-httpclient-5.2/library/README.md
Outdated
Show resolved
Hide resolved
laurit
approved these changes
Jan 26, 2024
trask
reviewed
Jan 29, 2024
instrumentation/apache-httpclient/apache-httpclient-5.2/library/build.gradle.kts
Outdated
Show resolved
Hide resolved
trask
reviewed
Jan 30, 2024
instrumentation/apache-httpclient/apache-httpclient-5.2/library/README.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
steverao
pushed a commit
to steverao/opentelemetry-java-instrumentation
that referenced
this pull request
Feb 16, 2024
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #10099