Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrumentation for armeria gRPC #11351

Merged
merged 5 commits into from
May 15, 2024
Merged

Conversation

laurit
Copy link
Contributor

@laurit laurit commented May 14, 2024

Resolves #6319
Resolves #9726
Supersedes #9662

@laurit laurit requested a review from a team May 14, 2024 11:53
@github-actions github-actions bot requested a review from theletterf May 14, 2024 11:53
static final AgentInstrumentationExtension testing = AgentInstrumentationExtension.create();

@RegisterExtension
static ServerExtension server =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
static ServerExtension server =
private final static ServerExtension server =

…pentelemetry/javaagent/instrumentation/armeria/grpc/v1_14/ArmeriaGrpcTest.java

Co-authored-by: Steve Rao <raozihao.rzh@alibaba-inc.com>
…pentelemetry/javaagent/instrumentation/armeria/grpc/v1_14/ArmeriaGrpcTest.java
@trask trask merged commit 66e4c5a into open-telemetry:main May 15, 2024
53 checks passed
@laurit laurit deleted the armeria-grpc branch May 20, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants