-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for informix connection string parsing in jdbc instrumentation #11542
Merged
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
51cbfb6
Add support for informix connection string parsing in jdbc instrument…
jaydeluca 6b11a66
support additional test case inputs with minimal connection string
jaydeluca e4e2587
fix variable name
jaydeluca ce2dda3
be consistent with the comparison operators
jaydeluca 798cbb2
solve for additional connection string variations
jaydeluca 7c8700b
solve for additional connection string variations
jaydeluca fe5261b
rework informix-direct parsing based on feedback
jaydeluca 0fe9ecd
Merge branch 'main' into jdbc-add-informix
laurit 9cb55fe
remove port from informix-direct
laurit a38b1e1
Merge branch 'main' into jdbc-add-informix
laurit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me this is strange. Looking at https://www.ibm.com/docs/en/informix-servers/12.10?topic=method-format-database-urls before
informix-direct
it saysDoes this mean that
informix-direct
is used when the server is connecting to somewhere? If that is the case should we bother with it at all? Considering that it is difficult to find info aboutinformix-direct
it might be the best option. There doesn't seem to be a host and port forinformix-direct
, if we are going to parse this then imo we should not fill these at all (could skipMODIFIED_URL_LIKE.doParse
andINFORMIX.doParse
calls).