Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable early jdk8 test #11777

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Enable early jdk8 test #11777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/publish-smoke-test-early-jdk8-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,4 @@ jobs:
if: always()
uses: ./.github/workflows/reusable-workflow-notification.yml
with:
success: >-
${{
needs.publishLinux.result == 'success' &&
needs.publishWindows.result == 'success'
}}
success: ${{ needs.publish.result == 'success' }}
9 changes: 1 addition & 8 deletions smoke-tests/src/test/groovy/io/opentelemetry/smoketest/CrashEarlyJdk8Test.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import org.testcontainers.containers.output.Slf4jLogConsumer
import org.testcontainers.containers.wait.strategy.Wait
import org.testcontainers.utility.DockerImageName
import org.testcontainers.utility.MountableFile
import spock.lang.Ignore
import spock.lang.IgnoreIf
import spock.lang.Specification

Expand All @@ -25,12 +24,6 @@ import static io.opentelemetry.smoketest.TestContainerManager.useWindowsContaine
// java.lang.invoke.CallSite
// This test verifies that such jvm does not crash with opentelemetry agent
@IgnoreIf({ useWindowsContainers() })
// com.github.dockerjava.api.exception.DockerClientException: Could not pull image: [DEPRECATION NOTICE]
// Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default
// and will be removed in an upcoming release. Suggest the author of docker.io/azul/zulu-openjdk:8u31
// to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2. More information
// at https://docs.docker.com/go/deprecated-image-specs/
@Ignore
class CrashEarlyJdk8Test extends Specification {
private static final Logger logger = LoggerFactory.getLogger(CrashEarlyJdk8Test)

Expand All @@ -40,7 +33,7 @@ class CrashEarlyJdk8Test extends Specification {
def "test crash on early jdk8"() {
setup:
GenericContainer target =
new GenericContainer<>(DockerImageName.parse("azul/zulu-openjdk:8u31"))
new GenericContainer<>(DockerImageName.parse("ghcr.io/open-telemetry/opentelemetry-java-instrumentation/smoke-test-zulu-openjdk-8u31:20240709.9848833570"))
.withStartupTimeout(Duration.ofMinutes(5))
.withLogConsumer(new Slf4jLogConsumer(logger))
.withCopyFileToContainer(
Expand Down
Loading