Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise gRPC version floor to 1.6 and use new context bridge API #2948

Merged
merged 3 commits into from
May 10, 2021

Conversation

anuraaga
Copy link
Contributor

@anuraaga anuraaga commented May 10, 2021

This raises the gRPC minimum version just a little bit (still 4+ years old) and uses a newly introduced context storage API that can return a value, removing the need for the side queues. Should improve performance nicely, and unfortunately I haven't been able to reproduce the issues in #2564 but by controlling the return value which gets passed back to us more directly, I think it does fix a corner case where the reference gets changed (I can't think of a reason the app wouldn't start because it would have been a harmless log message still though FWIU). The decoupling of current() and Storage.attach() in <=1.5 would allow them to be out of sync

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, that's so much nicer 💯

@anuraaga anuraaga merged commit 24998f5 into open-telemetry:main May 10, 2021
@iNikem
Copy link
Contributor

iNikem commented May 10, 2021

@anuraaga please update the list of supported libraries as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants