Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load InstrumentationModules using InstrumentationLoader #2971

Merged
merged 3 commits into from
May 13, 2021
Merged

Load InstrumentationModules using InstrumentationLoader #2971

merged 3 commits into from
May 13, 2021

Conversation

mateuszrzeszutek
Copy link
Member

This PR implements @iNikem's idea from this comment: #2879 (comment)

trask
trask approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

iNikem
iNikem approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@iNikem iNikem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if need 2 classes, InstrumentationLoader and InstrumentationModuleInstaller, but otherwise seems good :)

@mateuszrzeszutek
Copy link
Member Author

Not sure if need 2 classes, InstrumentationLoader and InstrumentationModuleInstaller

Probably not, but InstrumentationModuleInstaller is really complex even without loading SPIs right now, I didn't really want to add anything else to it.

@mateuszrzeszutek mateuszrzeszutek merged commit a72a783 into open-telemetry:main May 13, 2021
@mateuszrzeszutek mateuszrzeszutek deleted the instrumentation-loader branch May 13, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@iNikem iNikem iNikem approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

@jkwatson jkwatson Awaiting requested review from jkwatson

@laurit laurit Awaiting requested review from laurit

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mateuszrzeszutek @trask @iNikem