Change a couple of Longs to Integers in Instrumenter API #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
iNikem
reviewed
May 20, 2021
| @@ -43,7 +43,10 @@ protected final void onEnd(AttributesBuilder attributes, REQUEST request, RESPON | |||
| attributes, | |||
| SemanticAttributes.HTTP_REQUEST_CONTENT_LENGTH_UNCOMPRESSED, | |||
| requestContentLengthUncompressed(request, response)); | |||
| set(attributes, SemanticAttributes.HTTP_STATUS_CODE, statusCode(request, response)); | |||
| Integer statusCode = statusCode(request, response); | |||
| if (statusCode != null) { | |||
There was a problem hiding this comment.
I wonder if we should use OptionalInt instead?
There was a problem hiding this comment.
I think there's still reasonable chance of someone returning null even with OptionalInt, I guess nullable return has less chance of NPE.
There was a problem hiding this comment.
And we're never using any Optionals anywhere in the agent, so even if OptionalInt is a bit nicer and prettier @Nullable Integer is more consistent with the codebase.
anuraaga
approved these changes
May 20, 2021
| @@ -43,7 +43,10 @@ protected final void onEnd(AttributesBuilder attributes, REQUEST request, RESPON | |||
| attributes, | |||
| SemanticAttributes.HTTP_REQUEST_CONTENT_LENGTH_UNCOMPRESSED, | |||
| requestContentLengthUncompressed(request, response)); | |||
| set(attributes, SemanticAttributes.HTTP_STATUS_CODE, statusCode(request, response)); | |||
| Integer statusCode = statusCode(request, response); | |||
| if (statusCode != null) { | |||
There was a problem hiding this comment.
I think there's still reasonable chance of someone returning null even with OptionalInt, I guess nullable return has less chance of NPE.
mateuszrzeszutek
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two methods feel like they should return
Integer, and it also makes implementing them a bit easier: