Disable default resource providers in tests. #3288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
anuraaga
commented
Jun 14, 2021
| @@ -11,11 +11,6 @@ import spock.lang.Specification | |||
|
|
|||
| class InstrumentationModuleTest extends Specification { | |||
|
|
|||
| def setup() { | |||
| assert System.getenv().findAll { it.key.startsWith("OTEL_") }.isEmpty() | |||
There was a problem hiding this comment.
Couldn't figure out what these were here for
There was a problem hiding this comment.
Probably to make sure that we don't override default conf that we test below
There was a problem hiding this comment.
Yeah I thought it could be a reason - I'm comfortable with deleting since I don't think we do this in other tests
iNikem
approved these changes
Jun 14, 2021
| @@ -11,11 +11,6 @@ import spock.lang.Specification | |||
|
|
|||
| class InstrumentationModuleTest extends Specification { | |||
|
|
|||
| def setup() { | |||
| assert System.getenv().findAll { it.key.startsWith("OTEL_") }.isEmpty() | |||
There was a problem hiding this comment.
Probably to make sure that we don't override default conf that we test below
trask
approved these changes
Jun 14, 2021
robododge
pushed a commit
to robododge/opentelemetry-java-instrumentation
that referenced
this pull request
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds spam to assertion failures / log messages with no benefit