Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ForkJoinPool sometimes not instrumented #3293

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Fix ForkJoinPool sometimes not instrumented #3293

merged 1 commit into from
Jun 14, 2021

Conversation

trask
Copy link
Member

@trask trask commented Jun 14, 2021

Resolves #3292

anuraaga
anuraaga approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@laurit laurit merged commit 8be1006 into open-telemetry:main Jun 14, 2021
robododge pushed a commit to robododge/opentelemetry-java-instrumentation that referenced this pull request Jun 17, 2021
@trask @robododge
Fix ForkJoinPool sometimes not instrumented (open-telemetry#3293)
c9137a0
@trask trask deleted the fork-join-pool-sometimes-not-instrumented branch July 25, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@laurit laurit laurit approved these changes

@iNikem iNikem iNikem approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@jkwatson jkwatson Awaiting requested review from jkwatson

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExecutorInstrumentationTest is flaky, appears to be sporadic propagation failure across ForkJoinPool
5 participants
@trask @anuraaga @laurit @iNikem @mateuszrzeszutek