Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate context to cassandra4 callbacks #3371

Merged
merged 1 commit into from
Jun 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@
import io.opentelemetry.context.Context;
import io.opentelemetry.context.Scope;
import java.util.Optional;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.CompletionStage;
import java.util.function.Supplier;
import org.checkerframework.checker.nullness.qual.Nullable;

public class TracingCqlSession implements CqlSession {
Expand Down Expand Up @@ -188,29 +190,50 @@ public ResultSet execute(Statement<?> statement) {
public CompletionStage<AsyncResultSet> executeAsync(Statement<?> statement) {
String query = getQuery(statement);
CassandraRequest request = CassandraRequest.create(session, query);
Context context = instrumenter().start(Context.current(), request);
try (Scope ignored = context.makeCurrent()) {
CompletionStage<AsyncResultSet> stage = session.executeAsync(statement);
return stage.whenComplete(
(asyncResultSet, throwable) ->
instrumenter()
.end(context, request, getExecutionInfo(asyncResultSet, throwable), throwable));
}
return executeAsync(request, () -> session.executeAsync(statement));
}

@Override
public CompletionStage<AsyncResultSet> executeAsync(String query) {
CassandraRequest request = CassandraRequest.create(session, query);
Context context = instrumenter().start(Context.current(), request);
return executeAsync(request, () -> session.executeAsync(query));
}

private static CompletionStage<AsyncResultSet> executeAsync(
CassandraRequest request, Supplier<CompletionStage<AsyncResultSet>> query) {
Context parentContext = Context.current();
Context context = instrumenter().start(parentContext, request);
try (Scope ignored = context.makeCurrent()) {
CompletionStage<AsyncResultSet> stage = session.executeAsync(query);
return stage.whenComplete(
(asyncResultSet, throwable) ->
instrumenter()
.end(context, request, getExecutionInfo(asyncResultSet, throwable), throwable));
CompletionStage<AsyncResultSet> stage = query.get();
return wrap(
stage.whenComplete(
(asyncResultSet, throwable) ->
instrumenter()
.end(
context,
request,
getExecutionInfo(asyncResultSet, throwable),
throwable)),
parentContext);
}
}

static <T> CompletableFuture<T> wrap(CompletionStage<T> future, Context context) {
CompletableFuture<T> result = new CompletableFuture<>();
future.whenComplete(
(T value, Throwable throwable) -> {
try (Scope ignored = context.makeCurrent()) {
if (throwable != null) {
result.completeExceptionally(throwable);
} else {
result.complete(value);
}
}
});

return result;
}

private static String getQuery(Statement<?> statement) {
String query = null;
if (statement instanceof SimpleStatement) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,17 @@ class CassandraClientTest extends AgentInstrumentationSpecification {
CqlSession session = getSession(keyspace)

runUnderTrace("parent") {
session.executeAsync(statement).toCompletableFuture().get()
session.executeAsync(statement).toCompletableFuture().whenComplete({result, throwable ->
runUnderTrace("child") {}
}) .get()
}

expect:
assertTraces(1) {
trace(0, 2) {
trace(0, 3) {
basicSpan(it, 0, "parent")
cassandraSpan(it, 1, spanName, expectedStatement, operation, keyspace, table, span(0))
basicSpan(it, 2, "child", span(0))
}
}

Expand Down