Exclude duplicates from -all.jar #3430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
mateuszrzeszutek
approved these changes
Jun 29, 2021
|
Just wondering: did you run the bash command posted in that issue? Are there no duplicates left after this change? |
|
@mateuszrzeszutek Yeah confirmed no duplicates with the change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3405
I tried excluding duplicate dependencies from the javaagent-exporters project but found it quite complicated - in particular, while it's easy to exclude the declared dependencies (opentelemetry-sdk), excluding transitives (opentelemetry-sdk-trace) requires resolving configurations and adding lots of hairyness. This one line seems fine instead, since we apply dependency management I think it's unlikely we'd attempt to package different versions and smoke tests should catch anything fishy that could result from ignoring dupes.