Revert okhttp library instrumentation back to using standard reflection to support Android usage #3910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkwatson
requested review from
anuraaga,
iNikem,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
mateuszrzeszutek
approved these changes
Aug 23, 2021
|
Since this is a regression for Android, could we get a patch release with this commit, possibly? |
trask
approved these changes
Aug 23, 2021
| @@ -24,22 +23,19 @@ | |||
| private static final Cache<Request, Context> contextsByRequest = | |||
| Cache.newBuilder().setWeakKeys().build(); | |||
|
|
|||
| @Nullable private static MethodHandle timeoutMethodHandle; | |||
| @Nullable private static MethodHandle cloneMethodHandle; | |||
| @Nullable private static Method timeoutMethod; | |||
There was a problem hiding this comment.
can you add a comment here about not being able to use method handles (so no one changes it back), at least until we get some build tooling in place to prevent similar to otel-java repo?
anuraaga
approved these changes
Aug 23, 2021
anuraaga
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that MethodHandles are not supported on Android API levels 21-25.