Fix grpc instrumentation of callbacks #4097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
laurit
approved these changes
Sep 12, 2021
anuraaga
reviewed
Sep 13, 2021
| @@ -143,6 +143,124 @@ abstract class AbstractGrpcTest extends InstrumentationSpecification { | |||
| paramName << ["some name", "some other name"] | |||
| } | |||
|
|
|||
| def "test callback"() { | |||
There was a problem hiding this comment.
Can we add a test using GreeterFutureStub too? It should work but will test the more common usage.
anuraaga
reviewed
Sep 13, 2021
| AtomicReference<Throwable> error = new AtomicReference<>() | ||
| CountDownLatch latch = new CountDownLatch(1) | ||
| runWithSpan("parent") { | ||
| def future = client.sayHello(Helloworld.Request.newBuilder().setName("test").build()) |
There was a problem hiding this comment.
It's probably worth using the idiomatic API
def future = Futures.transform(
client.sayHelo(...)
response -> {
runWithSpan("child");
return response;
},
MoreExecutors.directExecutor());
try {
response.set(future.get());
} catch (Throwable t) {
error.set(t);
}
anuraaga
approved these changes
Sep 13, 2021
mateuszrzeszutek
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4088