Fix reactor context propagation in latest reactor #4377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4372 introduced in #4159
The newer reactor does not support a hack
dummy.flatMap(i -> publisher)
to force publisher inonNext
(i.e. withcurrent()
span)It seems there is optimization or some different path that causes the below branch to run, skipping context instrumentation
opentelemetry-java-instrumentation/instrumentation/reactor-3.1/library/src/main/java/io/opentelemetry/instrumentation/reactor/TracingOperator.java
Lines 91 to 94 in 51cf64b
One way to solve it would be to enable context propagation for scalars, but it probably would be bad for performance.
Instead, I went down the road of creating a small custom Mono impl instead of dummy that implements context propagation in
subscribe
call.