Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netty: preserve caught exception in the context instead of calling end() #4413

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

mateuszrzeszutek
Copy link
Member

No description provided.

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

at some point we'll want to tackle performance of the growing array based context (#4016)

error = t;
throw t;
} finally {
error = NettyErrorHolder.getOrDefault(context, error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it is a bit debatable whether we should use the exception that is in context or the one that happened here. Could be fine either way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't have any strong preference on one over another - I guess it's fine either way.

@trask trask merged commit 2e97a4d into open-telemetry:main Oct 19, 2021
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
@mateuszrzeszutek mateuszrzeszutek deleted the netty-error-handling branch November 18, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants