Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace DNS resolution in reactor-netty #4627

Merged

Conversation

mateuszrzeszutek
Copy link
Member

A continuation of #4587

Comment on lines 258 to +259
include(":instrumentation:netty:netty-4.1:javaagent")
include(":instrumentation:netty:netty-4.1-common:javaagent")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can netty-4.1-common:javaagent be merged into netty-4.1:javaagent and have reactor-netty:javaavent depend directly on netty-4.1:javaagent? or is there advantage to keeping it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it can! I don't know why I haven't thought of that 🙈
Done.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to go back to the netty-4.1-common idea, muzzle failed when I merged that into the main 4.1 module:

MUZZLE PASSED io.opentelemetry.javaagent.instrumentation.netty.v4_1.NettyInstrumentationModule BUT FAILURE WAS EXPECTED

@mateuszrzeszutek mateuszrzeszutek merged commit cd119f4 into open-telemetry:main Nov 16, 2021
@mateuszrzeszutek mateuszrzeszutek deleted the reactor-netty-resolve branch November 16, 2021 07:34
@trask trask mentioned this pull request May 5, 2022
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
* Trace DNS resolution in reactor-netty

* Code review comments

* removed a little too much

* implementation -> api

* revert and make muzzle happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants