-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrument ContextPropagationOperator to bridge lib/agent calls #4786
Instrument ContextPropagationOperator to bridge lib/agent calls #4786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx @lmolkova!
@mateuszrzeszutek @anuraaga would be great to get your thoughts on this. It's similar to the bridging we do on the OpenTelemetry API, but applied to a library instrumentation, which feels a little odd since typically I think of users using either library instrumentation -or- javaagent instrumentation, but not needing to use both. Maybe we could split out part of the reactor instrumentation module into an opentelemetry-extension-reactor
module (similar to opentelemetry-extension-kotlin)?
public class ContextPropagationOperatorInstrumentation implements TypeInstrumentation { | ||
@Override | ||
public ElementMatcher<TypeDescription> typeMatcher() { | ||
return named("application.io.opentelemetry.instrumentation.reactor.ContextPropagationOperator"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Library itself can provide native/library instrumentation and then app developer brings in the agent. So this scenario is totally possible. |
...entelemetry/javaagent/instrumentation/reactor/ContextPropagationOperatorInstrumentation.java
Outdated
Show resolved
Hide resolved
I like this PR (and muzzle changes in #4797); perhaps we'll need to implement a similar bridge for the |
c661bde
to
b19b66f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks!
…-telemetry#4786) * Instrument ContextPropagationOperator to bridge lib/agent calls * more tests * clean up * up * lint * more lint * make runWithContext(Flux, ..) public * lint
Fixes reactor part of #4666