Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework context propagation to redisson async callback #5748

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Apr 4, 2022

Lately (since release of 3.17.0?) redisson latest dep tests have been flaky https://ge.opentelemetry.io/scans/tests?search.buildOutcome=success&search.relativeStartTime=P7D&search.tags=CI&search.timeZoneId=Europe/Tallinn&tests.container=RedissonAsyncClientTest&tests.sortField=FLAKY&tests.test=test%20future%20whenComplete&tests.unstableOnly=true
I wasn't able to reproduce it. I suspect the issue is that currently we set the context we wish to use for callbacks deep in the request handling where it will get chained through other completable futures. Hopefully setting the context closer to the callback will work better.

@laurit laurit requested a review from a team April 4, 2022 15:09
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect the issue is that currently we set the context we wish to use for callbacks deep in the request handling where it will get chained through other completable futures. Hopefully setting the context closer to the callback will work better.

If you could add a comment like this in the code, I think it would be helpful, otherwise it's not obvious why we wouldn't use the same wrapper for both, and tests wouldn't reveal any problem if someone tried to "simplify" this in the future.

@laurit
Copy link
Contributor Author

laurit commented Apr 5, 2022

I suspect the issue is that currently we set the context we wish to use for callbacks deep in the request handling where it will get chained through other completable futures. Hopefully setting the context closer to the callback will work better.

If you could add a comment like this in the code, I think it would be helpful, otherwise it's not obvious why we wouldn't use the same wrapper for both, and tests wouldn't reveal any problem if someone tried to "simplify" this in the future.

@trask comment added, could you review

@trask
Copy link
Member

trask commented Apr 5, 2022

@trask comment added, could you review

thx 👍

@trask trask merged commit 27e8201 into open-telemetry:main Apr 5, 2022
@laurit laurit deleted the rework-redisson-callback branch May 17, 2022 13:14
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
…#5748)

* Rework context propagation to redisson async callback

* add comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants