Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude spring temporary type matching class loader #5912

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Apr 22, 2022

When load time weaving is enabled spring loads classes into a temporary class loader to do type matching (is this a factory bean? etc.). As this type matching class loader is recreated for each type matching attempt there can be a lot of them. For each class loader we run a bunch of matchers that call getResource. With these temp class loaders this can consume excessive amount of time. As we don't really need to instrument the classes in temp class loaders we can just exclude it.

@laurit laurit requested a review from a team April 22, 2022 11:26
@trask trask merged commit 4d0564a into open-telemetry:main Apr 22, 2022
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
@laurit laurit deleted the exclude-sping-temp-class-loader branch July 6, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants