Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture messaging header value as span attribute #6454

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Aug 10, 2022

Resolves #6293
Resolves #5238
Implements capturing messaging header value as span attribute similarly to how HTTP headers are captured.

@laurit laurit requested a review from a team August 10, 2022 15:04
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Map<String, String> testConfig = new HashMap<>();
testConfig.put(
"otel.instrumentation.messaging.experimental.capture-headers",
"test-message-header, test-message-int-header, test_message_header, test_message_int_header");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a brief comment why both - and _ variants?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment added, basically it is because in jms2 tests hornetq complained that test-message-header is not a valid jms property name

@trask trask merged commit 07d7cfd into open-telemetry:main Aug 12, 2022
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 23, 2022
* Capture messaging header value as span attribute

* add comment
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
* Capture messaging header value as span attribute

* add comment
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
* Capture messaging header value as span attribute

* add comment
@laurit laurit deleted the capute-messaging-header branch July 6, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect RabbitMQ message headers Collecting kafka message headers in labels.
3 participants