Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #6499

Merged
merged 7 commits into from
Sep 6, 2022
Merged

Conversation

mateuszrzeszutek
Copy link
Member

No description provided.

@mateuszrzeszutek mateuszrzeszutek requested a review from a team August 23, 2022 06:37
@mateuszrzeszutek mateuszrzeszutek marked this pull request as draft August 23, 2022 11:40
@mateuszrzeszutek
Copy link
Member Author

Looks like we'll have to wait for a stable logback release first

@mateuszrzeszutek mateuszrzeszutek changed the title Bump slf4j version to 2.0.0 Update dependencies Aug 30, 2022
@mateuszrzeszutek mateuszrzeszutek marked this pull request as ready for review August 30, 2022 06:40
@mateuszrzeszutek
Copy link
Member Author

Looks like "our" slf4j (version 2) is conflicting with slf4j from tested libraries (like spring boot; version 1.x): java.lang.NoClassDefFoundError: org/slf4j/impl/StaticLoggerBinder

I wonder if we should just get rid of any slf4j references from our tests, and replace them all with JUL. @trask WDYT?

@trask
Copy link
Member

trask commented Aug 30, 2022

I wonder if we should just get rid of any slf4j references from our tests, and replace them all with JUL. @trask WDYT?

makes sense to me given the breaking slf4j changes

@laurit
Copy link
Contributor

laurit commented Aug 30, 2022

I wonder if we should just get rid of any slf4j references from our tests, and replace them all with JUL. @trask WDYT?

It is probably not going to be that easy. At least armeria and testcontainers uses slf4j so you'll probably have to do some shading.

@mateuszrzeszutek
Copy link
Member Author

It is probably not going to be that easy. At least armeria and testcontainers uses slf4j so you'll probably have to do some shading.

We can shade armeria, and redirect its logs to JUL, that's a minor problem. Testcontainers though...

The overall goal here should be to decouple the slf4j version used inside the javaagent (and remove it from the dependencyManagement perhaps) from the slf4j version(s) used inside the tests; so maybe it would be just fine to leave it unspecified and let gradle determine what version to use via transitive dependencies.

@trask trask merged commit 0d6f0b1 into open-telemetry:main Sep 6, 2022
@mateuszrzeszutek mateuszrzeszutek deleted the bump-slf4j-version branch September 7, 2022 06:14
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 23, 2022
* Update dependencies

* Strictly pin slf4j and logback versions

* logback 1.3

* Only use slf4j 2.0.0 internally in the javaagent

* Pre-initialize slf4j provider

* Bump jackson version

* licenses
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
* Update dependencies

* Strictly pin slf4j and logback versions

* logback 1.3

* Only use slf4j 2.0.0 internally in the javaagent

* Pre-initialize slf4j provider

* Bump jackson version

* licenses
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
* Update dependencies

* Strictly pin slf4j and logback versions

* logback 1.3

* Only use slf4j 2.0.0 internally in the javaagent

* Pre-initialize slf4j provider

* Bump jackson version

* licenses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants