-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #6499
Update dependencies #6499
Conversation
Looks like we'll have to wait for a stable logback release first |
c842878
to
6620dc7
Compare
6620dc7
to
1a95cdd
Compare
Looks like "our" slf4j (version 2) is conflicting with slf4j from tested libraries (like spring boot; version 1.x): I wonder if we should just get rid of any slf4j references from our tests, and replace them all with JUL. @trask WDYT? |
makes sense to me given the breaking slf4j changes |
It is probably not going to be that easy. At least armeria and testcontainers uses slf4j so you'll probably have to do some shading. |
We can shade armeria, and redirect its logs to JUL, that's a minor problem. Testcontainers though... The overall goal here should be to decouple the slf4j version used inside the javaagent (and remove it from the |
cf84a35
to
13693a4
Compare
* Update dependencies * Strictly pin slf4j and logback versions * logback 1.3 * Only use slf4j 2.0.0 internally in the javaagent * Pre-initialize slf4j provider * Bump jackson version * licenses
* Update dependencies * Strictly pin slf4j and logback versions * logback 1.3 * Only use slf4j 2.0.0 internally in the javaagent * Pre-initialize slf4j provider * Bump jackson version * licenses
* Update dependencies * Strictly pin slf4j and logback versions * logback 1.3 * Only use slf4j 2.0.0 internally in the javaagent * Pre-initialize slf4j provider * Bump jackson version * licenses
No description provided.