Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OWASP dependency check #6978

Merged
merged 9 commits into from
Oct 28, 2022
Merged

Add OWASP dependency check #6978

merged 9 commits into from
Oct 28, 2022

Conversation

trask
Copy link
Member

@trask trask commented Oct 26, 2022

See comment in the github action that explains why I think this is helpful:

the benefit of this over dependabot is that this also analyzes transitive dependencies
while dependabot (at least currently) only analyzes top-level dependencies

@trask trask marked this pull request as ready for review October 26, 2022 04:47
@trask trask requested a review from a team October 26, 2022 04:47
dependencyCheck {
skipConfigurations = listOf("errorprone", "checkstyle", "annotationProcessor")
suppressionFile = "buildscripts/dependency-check-suppressions.xml"
failBuildOnCVSS = 7f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does 7f mean?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question, added comment

@trask trask merged commit cd95517 into open-telemetry:main Oct 28, 2022
@trask trask deleted the add-owasp-gradle-plugin branch October 28, 2022 02:21
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
See comment in the github action that explains why I think this is
helpful:

> the benefit of this over dependabot is that this also analyzes
transitive dependencies
> while dependabot (at least currently) only analyzes top-level
dependencies
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
See comment in the github action that explains why I think this is
helpful:

> the benefit of this over dependabot is that this also analyzes
transitive dependencies
> while dependabot (at least currently) only analyzes top-level
dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants