Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instrumentation suppression keys that do not align with their module name #7811

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Update instrumentation suppression keys that do not align with their module name #7811

merged 2 commits into from
Apr 11, 2023

Conversation

trask
Copy link
Member

@trask trask commented Feb 14, 2023

No description provided.

@trask trask requested a review from a team February 14, 2023 20:13
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll also need to update the names here after the release

@laurit
Copy link
Contributor

laurit commented Feb 15, 2023

@trask do you plan to do a similar change for jaxws/jaxrs frameworks?

@trask
Copy link
Member Author

trask commented Feb 15, 2023

@trask do you plan to do a similar change for jaxws/jaxrs frameworks?

good point, let's hold on this PR for current release, and I'll do a pass through all modules

@trask trask marked this pull request as draft February 15, 2023 19:34
@trask trask changed the title Update jsf instrumentation names Update instrumentation suppression keys that do not align with their module name Feb 16, 2023
@trask trask marked this pull request as ready for review April 2, 2023 01:49
@trask trask added this to the v1.25.0 milestone Apr 6, 2023
@trask trask merged commit 66f4c80 into open-telemetry:main Apr 11, 2023
@trask trask deleted the update-instrumentation-names branch April 11, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants