Fix http attributes of AWS SDK V2 instrumentation #8931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Populate http span attributes during beforeTransmission in the AWS SDK v2 instrumentation so that a request is instrumented after it is fully transformed by other interceptors. Signed-off-by: Raphael Silva <rapphil@gmail.com>
laurit
reviewed
Jul 12, 2023
instrumentation/aws-sdk/aws-sdk-2.2/javaagent/src/test/java/QueryProtocolModelTest.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Jul 12, 2023
instrumentation/aws-sdk/aws-sdk-2.2/javaagent/src/test/java/QueryProtocolModelTest.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Jul 12, 2023
instrumentation/aws-sdk/aws-sdk-2.2/javaagent/src/test/java/QueryProtocolModelTest.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Jul 12, 2023
instrumentation/aws-sdk/aws-sdk-2.2/javaagent/src/test/java/QueryProtocolModelTest.java
Outdated
Show resolved
Hide resolved
jeanbisutti
reviewed
Jul 12, 2023
...c/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AbstractQueryProtocolModelTest.java
Outdated
Show resolved
Hide resolved
instrumentation/aws-sdk/aws-sdk-2.2/javaagent/src/test/java/QueryProtocolModelTest.java
Outdated
Show resolved
Hide resolved
…pentelemetry/instrumentation/awssdk/v2_2/AbstractQueryProtocolModelTest.java Co-authored-by: Jean Bisutti <jean.bisutti@gmail.com>
…eryProtocolModelTest.java Co-authored-by: Jean Bisutti <jean.bisutti@gmail.com>
Signed-off-by: Raphael Silva <rapphil@gmail.com>
Signed-off-by: Raphael Silva <rapphil@gmail.com>
Signed-off-by: Raphael Silva <rapphil@gmail.com>
trask
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Populate http attributes of the span generated by the AWS SDK v2 instrumentation during
beforeTransmissionin theTracingExecutionInterceptorso that a request is instrumented after it is fully transformed by other interceptors.p.s.: That is why we get access to the
USER_AGENT_ORIGINALsemantic attribute in all the test cases now.This pr also changes how the s3 client is being tested due to differences introduced by the aws sdk v2.18.0 with regards to forcing the usage of virtual-hosted-style access in s3.. Tests no longer relies on the
testLatestDepsproperty and instead assert for both possibilities since both are correct (with and without virtual-hosted-style).