Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return default DbInfo when connection is null #9413

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

ebyhr
Copy link
Contributor

@ebyhr ebyhr commented Sep 8, 2023

Otherwise, this method may cause NPE.

@ebyhr ebyhr requested a review from a team September 8, 2023 04:53
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 8, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ebyhr / name: Yuya Ebihara (81b9448)

@laurit
Copy link
Contributor

laurit commented Sep 8, 2023

@ebyhr is this a hypothetical NPE or did you actually get one? I think the connection could be null in

@ebyhr
Copy link
Contributor Author

ebyhr commented Sep 8, 2023

@laurit Thanks for your review. I actually received NPE. I'm still investigating why the connection was null.

@trask trask merged commit 2fb0004 into open-telemetry:main Sep 8, 2023
46 checks passed
@ebyhr ebyhr deleted the ebi/jdbc-npe branch September 12, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants